Repository navigation
docs(tokens): approving a desktop app sign-in needs Create Token in any of your organizations - #1348
Conversation
…ny of your organizations Signed-off-by: Lee Calcote <lee.calcote@layer5.io>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Description Check |  |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | |
The title clearly and concisely describes the documented permission change for approving desktop app sign-ins. It accurately states that Create Token permission can exist in any organization the user … |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
Full details: Title check
-
Explanation
The title clearly and concisely describes the documented permission change for approving desktop app sign-ins. It accurately states that Create Token permission can exist in any organization the user belongs to.
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
|
Preview deployment for PR #1348 removed. This PR preview was automatically pruned because we keep only the 6 most recently updated previews on GitHub Pages to stay within deployment size limits. If needed, push a new commit to this PR to generate a fresh preview. |
Fold the behavior corrections from the reverted Cloud restructure into the pages they originally covered, keeping their URLs, titles and structure. Re-apply later Cloud edits from #1281, #1286, #1326, #1335, #1337, #1338, #1339, #1340, #1341, #1342, #1343, #1348 and #1349. Remove unshipped claims from the Kanvas tutorials. Add aliases so URLs published during the restructure keep resolving. Signed-off-by: Mia Grenell <184569369+miacycle@users.noreply.github.com>
Approving a desktop app or CLI sign-in now checks Create Token in at least one organization you belong to, not the selected organization or the custom domain's organization. Companion to the layer5io/meshery-cloud fix for native sign-in on custom domains.
Summary by CodeRabbit